fix: update secret label when getting with both id and label #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
approved these changes
Aug 12, 2024
| @@ -424,6 +427,9 @@ def secret_info_get( | |||
| label: Optional[str] = None, | |||
| ) -> SecretInfo: | |||
| secret = self._get_secret(id, label) | |||
| # If both the id and label are provided, then update the label. | |||
There was a problem hiding this comment.
should we be doing this in _get_secret?
we-re side-effecting anyway, so...
There was a problem hiding this comment.
I wondered about that. _get_secret is used by three other methods - for grant/revoke it's not relevant, but the code would skipped anyway because the label will always be None. For set, it is relevant, but it's already done because it's updating potentially all the metadata.
So it's either updated twice in set or there's the code duplication. Maybe it's just cleaner in _get_secret so that's the better choice.
There was a problem hiding this comment.
mmm right. I'm 50-50 on this one, I don't mind either way ;)
tonyandrewmeyer
added a commit
that referenced
this pull request
Sep 2, 2024
When we get a secret and provide both ID and label, the label should update to the provided one. This was previously missing in Scenario. Fixes #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get a secret and provide both ID and label, the label should update to the provided one. This was previously missing in Scenario.
Fixes #95